Custom exceptionsand greater type safety. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ween floats/doubles and bitset). noexcept specifier added to functions that won't throw exceptions (most things except read/write from a file stream, which cannot be guaranteed). Minor documentation updates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 99.14% 99.71% +0.57%
==========================================
Files 1 2 +1
Lines 940 1069 +129
==========================================
+ Hits 932 1066 +134
+ Misses 8 3 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use custom exception (sacfmt::io_error).
Updated float_to_binary and double_to_binary to use a typesafe conversion (float/double -> correctly-sized uint -> bitset instead of float/double -> bitset).
noexcept specifier has been added to functions/methods that won't throw exceptions (basically everything except explicit I/O operations, which cannot be guaranteed.