-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade solidity-coverage to v0.6+ #541
Conversation
@sohkai Taking a look today... |
@sohkai Could you retry with Also left some notes about failing coverage jobs for aragon-apps at this issue thread in solidity-coverage. |
@cgewecke Can confirm with the new version that all the ETH transfers are working under coverage 🎉. Thanks so much for helping out on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hell yea!!! 🤟🤟🤟🤟
Let's create an issue to tackle the uncovered lines |
@facuspagnuolo Not sure why coverage decreased (if anything, not skipping those tests should increase it...), but we do have #514 for the few areas of coverage we previously missed :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🙌🙌
Upgrades
solidity-coverage
.A number of tests invoking the fallback function are now failing with an out of gas on the new version, likely due to new instrumentation rules. Previously they were operating within the limit, even under instrumentation.
cc @cgewecke