Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Books with an id containing a hyphen/dash/underscore are not handled properly #9

Open
Eddict opened this issue Apr 17, 2021 · 0 comments
Open

Books with an id containing a hyphen/dash/underscore are not handled properly #9

Eddict opened this issue Apr 17, 2021 · 0 comments

Comments

@Eddict
Copy link

Eddict commented Apr 17, 2021 •
edited
Loading

eg. https://books.google.nl/books?id=S-Fu4fGHnlAC
eg. https://books.google.nl/books?id=J2jC7gH_4xAC

can be solved by correcting the regex

def get_book_url():
    
    if re.findall(r"id=[A-Za-z0-9-_]+", url):
        id_part = re.findall(r"id=[A-Za-z0-9-_]+", url)[-1]
@Eddict Eddict changed the title Books with an id containing a hyphen/dash are not handled properly Books with an id containing a hyphen/dash/underscore are not handled properly Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Eddict