-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to SvelteKit 2 #733
Conversation
@benmccann is attempting to deploy a commit to the appwrite Team on Vercel. A member of the Team first needs to authorize it. |
hey @benmccann 👋🏻 I'll be able to take some time to review it tomorrow 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @benmccann thank you for this PR 🎉
Looks good! I think there are still some goto
that lead to external sources like
await goto(`appwrite-callback-${projectId}://${$page.url.search}`); |
And a couple other places where we redirect to
appwrite-callback-
👍
Thanks for the reviews! I've updated those |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What does this PR do?
Upgrade to SvelteKit 2
Test Plan
I actually couldn't get this project to build on
main
. This PR fixes it. This is my first PR to the project though, so I wouldn't mind an extra set of eyesRelated PRs and Issues
I'm also upgrading
prettier
in #725Have you read the Contributing Guidelines on issues?
no