Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to SvelteKit 2 #733

Merged
merged 12 commits into from
Jan 30, 2024
Merged

upgrade to SvelteKit 2 #733

merged 12 commits into from
Jan 30, 2024

Conversation

benmccann
Copy link
Contributor

What does this PR do?

Upgrade to SvelteKit 2

Test Plan

I actually couldn't get this project to build on main. This PR fixes it. This is my first PR to the project though, so I wouldn't mind an extra set of eyes

Related PRs and Issues

I'm also upgrading prettier in #725

Have you read the Contributing Guidelines on issues?

no

Copy link

vercel bot commented Jan 17, 2024

@benmccann is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@TorstenDittmann
Copy link
Contributor

hey @benmccann 👋🏻

I'll be able to take some time to review it tomorrow 😄

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @benmccann thank you for this PR 🎉
Looks good! I think there are still some goto that lead to external sources like

await goto(`appwrite-callback-${projectId}://${$page.url.search}`);

And a couple other places where we redirect to appwrite-callback- 👍

@benmccann
Copy link
Contributor Author

Thanks for the reviews! I've updated those goto calls. I didn't invoke resolve in those calls as was being done previously since it's now invoking the browser API directly and there's not really a way for it to succeed or fail that we would worry about and you're no longer in the application once window.location has been updated

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:56pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:56pm
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 5:56pm

@TorstenDittmann TorstenDittmann merged commit e11d985 into appwrite:main Jan 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants