Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add APPPACK_ACCOUNT env variable #69

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

CuriousLearner
Copy link
Contributor

@CuriousLearner CuriousLearner commented Jun 19, 2024

Uses APPPACK_ACCOUNT env variable to substitute with the -c flag

Raises error if user has multiple accounts and neither of them is set.

Fixes #64

@CuriousLearner CuriousLearner requested a review from ipmb June 19, 2024 14:38
@ipmb
Copy link
Member

ipmb commented Aug 28, 2024

This should be noted in the docs unless the intent is for it to be a hidden feature.

…apppack-account-var

* 'main' of https://github.com/apppackio/apppack:
  fix: Prevent Ctrl+C from exiting remote shell (#71)
@CuriousLearner
Copy link
Contributor Author

Updated docs in here: apppackio/apppack-docs#8

@ipmb
Copy link
Member

ipmb commented Aug 28, 2024

Sorry, I should've been clearer. Could you add it to the help text for -c here in this repo?

@CuriousLearner CuriousLearner merged commit cf06763 into main Aug 28, 2024
4 checks passed
@CuriousLearner CuriousLearner deleted the use-apppack-account-var branch August 28, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use APPPACK_ACCOUNT env var to use account if not overridden with -c flag
2 participants