Add missing assembly files to CMake and generator script #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update both the CMakeLists.txt for CCryptoBoringSSL and the CMakeLists.txt generator so that it can add platform-independent assembly files.
Checklist
If you've made changes to
gyb
files./scripts/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
There are downstream linker failures due to missing symbols from certain platform neutral assembly files.
Modifications:
The
scripts/update-cmake-lists.sh
has an updated find expression to discover platform-independent assembly files and includes them in theCMakeLists.txt
files.Result:
There will be more symbols included from third-parties such as BoringSSL.