Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing assembly files to CMake and generator script #322

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cmcgee1024
Copy link

@cmcgee1024 cmcgee1024 commented Feb 7, 2025

Update both the CMakeLists.txt for CCryptoBoringSSL and the CMakeLists.txt generator so that it can add platform-independent assembly files.

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run ./scripts/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

There are downstream linker failures due to missing symbols from certain platform neutral assembly files.

Modifications:

The scripts/update-cmake-lists.sh has an updated find expression to discover platform-independent assembly files and includes them in the CMakeLists.txt files.

Result:

There will be more symbols included from third-parties such as BoringSSL.

@Lukasa Lukasa added semver/none No version bump required. 🔨 semver/patch No public API change. and removed semver/none No version bump required. labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants