Skip to content

Commit 7b16701

Browse files
The Pkl Team (automation)holzensp
The Pkl Team (automation)
authored andcommitted
[pkl.experimental.syntax] Do not generate spaces at EOL for long typealiases
1 parent 3528213 commit 7b16701

File tree

9 files changed

+71
-14
lines changed

9 files changed

+71
-14
lines changed

packages/k8s.contrib.crd/PklProject

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ dependencies {
2929
}
3030

3131
package {
32-
version = "1.0.7"
32+
version = "1.0.8"
3333
}

packages/k8s.contrib.crd/PklProject.deps.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
},
1616
"package://pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib@1": {
1717
"type": "local",
18-
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib@1.0.8",
18+
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib@1.0.9",
1919
"path": "../org.json_schema.contrib"
2020
},
2121
"package://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1": {
2222
"type": "local",
23-
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1.0.2",
23+
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1.0.3",
2424
"path": "../pkl.experimental.syntax"
2525
},
2626
"package://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.uri@1": {

packages/org.json_schema.contrib/PklProject

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ dependencies {
2525
}
2626

2727
package {
28-
version = "1.0.8"
28+
version = "1.0.9"
2929
}

packages/org.json_schema.contrib/PklProject.deps.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"resolvedDependencies": {
44
"package://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1": {
55
"type": "local",
6-
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1.0.2",
6+
"uri": "projectpackage://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.syntax@1.0.3",
77
"path": "../pkl.experimental.syntax"
88
},
99
"package://pkg.pkl-lang.org/pkl-pantry/pkl.experimental.uri@1": {

packages/pkl.experimental.syntax/PklProject

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@
1717
amends "../basePklProject.pkl"
1818

1919
package {
20-
version = "1.0.2"
20+
version = "1.0.3"
2121
apiTests = import*("tests/*.pkl").keys.toListing()
2222
}

packages/pkl.experimental.syntax/TypeAliasNode.pkl

+11-2
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,21 @@ annotations: Listing<AnnotationNode>?
3232

3333
modifiers: Listing<"external"|"local">(isDistinct)?
3434

35-
local function renderAlias(currentIndent: String) = new Listing {
35+
local function renderAlias(currentIndent: String) =
36+
let (typeRendered = type.render(currentIndent))
37+
new Listing {
38+
renderHeader(currentIndent)
39+
when (!typeRendered.startsWith("\n")) { // if the type is rendered starting on the next line, do not add a space
40+
" "
41+
}
42+
typeRendered
43+
}.join("")
44+
45+
function renderHeader(currentIndent: String) = new Listing {
3646
...?modifiers
3747
"typealias"
3848
name.render(currentIndent)
3949
"="
40-
type.render(currentIndent)
4150
}.join(" ")
4251

4352
function render(currentIndent: String) = List(

packages/pkl.experimental.syntax/tests/ExpressionNode.pkl-expected.pcf

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
examples {
22
["binary operators - basic"] {
3-
"\"foo\" + \"bar\""
3+
#""foo" + "bar""#
44
}
55
["binary operators - precedence: no parentheses when child precedence is higher"] {
66
"5 * 5 + 5 * 5"
@@ -39,10 +39,10 @@ examples {
3939
"super.someProperty(true)"
4040
}
4141
["super subscript"] {
42-
"super[\"test\"]"
42+
#"super["test"]"#
4343
}
4444
["subscript"] {
45-
"test[\"key\"]"
45+
#"test["key"]"#
4646
"""
4747
(if (test)
4848
testTrue
@@ -51,9 +51,9 @@ examples {
5151
"""
5252
}
5353
["read"] {
54-
"read(\"env:HOME\")"
55-
"read*(\"env:HOME\")"
56-
"read?(\"env:HOME\")"
54+
#"read("env:HOME")"#
55+
#"read*("env:HOME")"#
56+
#"read?("env:HOME")"#
5757
}
5858
["trace"] {
5959
"trace(test)"

packages/pkl.experimental.syntax/tests/ModuleNode.pkl

+31
Original file line numberDiff line numberDiff line change
@@ -167,4 +167,35 @@ examples {
167167
}
168168
}.output.text
169169
}
170+
["typealiases"] {
171+
new ModuleNode {
172+
typealiases {
173+
new {
174+
name { value = "Short" }
175+
type = new TypeNode.UnionTypeNode {
176+
members {
177+
new TypeNode.StringLiteralTypeNode { value = "A" }
178+
new TypeNode.StringLiteralTypeNode { value = "B" }
179+
}
180+
}
181+
}
182+
new {
183+
name { value = "Long" }
184+
type = new TypeNode.UnionTypeNode {
185+
members {
186+
new TypeNode.StringLiteralTypeNode { value = "Apple" }
187+
new TypeNode.StringLiteralTypeNode { value = "Blackberry" }
188+
new TypeNode.StringLiteralTypeNode { value = "Cherry" }
189+
new TypeNode.StringLiteralTypeNode { value = "Durian" }
190+
new TypeNode.StringLiteralTypeNode { value = "Elderberry" }
191+
new TypeNode.StringLiteralTypeNode { value = "Fig" }
192+
new TypeNode.StringLiteralTypeNode { value = "Guava" }
193+
new TypeNode.StringLiteralTypeNode { value = "Huckleberry" }
194+
new TypeNode.StringLiteralTypeNode { value = "I_can't_think_of_a_fruit_that_starts_with_I" }
195+
}
196+
}
197+
}
198+
}
199+
}.output.text
200+
}
170201
}

packages/pkl.experimental.syntax/tests/ModuleNode.pkl-expected.pcf

+17
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,23 @@ examples {
3232
value = inputIntegerValue + 5
3333
}
3434

35+
"""
36+
}
37+
["typealiases"] {
38+
"""
39+
typealias Short = "A"|"B"
40+
41+
typealias Long =
42+
"Apple"
43+
|"Blackberry"
44+
|"Cherry"
45+
|"Durian"
46+
|"Elderberry"
47+
|"Fig"
48+
|"Guava"
49+
|"Huckleberry"
50+
|"I_can't_think_of_a_fruit_that_starts_with_I"
51+
3552
"""
3653
}
3754
}

0 commit comments

Comments
 (0)