Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity caching: sort entity keys before hashing the key #6799

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Feb 14, 2025

Part of #6673


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested review from a team as code owners February 14, 2025 11:23
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Feb 14, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: dd27b869d891120bd4117df2

Copy link
Contributor

@bnjjj, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj
Copy link
Contributor Author

bnjjj commented Feb 17, 2025

I found a better implementation but it's waiting for apollographql/serde_json_bytes#20 to be merged

@bnjjj bnjjj marked this pull request as draft February 17, 2025 10:19
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj marked this pull request as ready for review February 18, 2025 09:36
@bnjjj bnjjj requested a review from BrynCooke February 18, 2025 09:37
bnjjj and others added 2 commits February 21, 2025 10:33
Co-authored-by: Renée <renee.kooi@apollographql.com>
Signed-off-by: Benjamin <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from goto-bus-stop February 21, 2025 09:44
@bnjjj bnjjj requested a review from IvanGoncharov March 1, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants