Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router v2: Gauge are not exporter to prometheus #6859

Open
yanns opened this issue Feb 25, 2025 · 3 comments · May be fixed by #6860
Open

Router v2: Gauge are not exporter to prometheus #6859

yanns opened this issue Feb 25, 2025 · 3 comments · May be fixed by #6860

Comments

@yanns
Copy link
Contributor

yanns commented Feb 25, 2025

Describe the bug

I'm migrating some rust plugins from router v1 to router v2.
For metrics, I'm using the new approach with:

let meter = meter_provider().meter("apollo/router");

I'm using counter, histograms and gauge.
Counters and histograms are exported in /metrics used by prometheus, as expected.
Gauges are not exported.

I still don't understand what is wrong only with Gauges.
By looking at the code, I've found it that Gauge is being commented out in

, but I'm not sure it's related.

Desktop (please complete the following information):

  • Version 2.0.0
yanns added a commit to yanns/router that referenced this issue Feb 25, 2025
@yanns yanns linked a pull request Feb 25, 2025 that will close this issue
@yanns
Copy link
Contributor Author

yanns commented Feb 25, 2025

Here is a test probably reproducing the issue #6860

@yanns
Copy link
Contributor Author

yanns commented Feb 25, 2025

In 911780c, I've tried to add support for SyncGauge, but the test is still failing.

@yanns
Copy link
Contributor Author

yanns commented Feb 25, 2025

I could finally fix by adding b76d71b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant