Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate the topology as immutable #8894

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Feb 7, 2025

close #8892

@leon-inf leon-inf added this to the Release 1.0.0 milestone Feb 7, 2025
@leon-inf leon-inf requested review from Y-Rookie and a team as code owners February 7, 2025 08:38
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Feb 7, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (24892e7) to head (61f7624).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8894      +/-   ##
==========================================
+ Coverage   60.15%   60.41%   +0.25%     
==========================================
  Files         382      382              
  Lines       46331    46331              
==========================================
+ Hits        27871    27990     +119     
+ Misses      15784    15664     -120     
- Partials     2676     2677       +1     
Flag Coverage Δ
unittests 60.41% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf merged commit da8c324 into main Feb 7, 2025
43 checks passed
@leon-inf leon-inf deleted the bugfix/immutable-topology branch February 7, 2025 13:06
@leon-inf
Copy link
Contributor Author

leon-inf commented Feb 7, 2025

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13200459296

apecloud-bot pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cluster Topology Can Be Modified but Changes Do Not Take Effect
5 participants