Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the config template referenced might be empty #8880

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

leon-inf
Copy link
Contributor

@leon-inf leon-inf commented Feb 6, 2025

No description provided.

@leon-inf leon-inf added this to the Release 1.0.0 milestone Feb 6, 2025
@leon-inf leon-inf requested review from sophon-zt and a team as code owners February 6, 2025 09:39
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 6, 2025
Copy link
Contributor

@shanshanying shanshanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after overriding, we should make sure each tempatehas non-emptytemplateRef`.

@leon-inf leon-inf force-pushed the support/config-template-empty branch from 58b7a7b to 0d2df29 Compare February 6, 2025 09:50
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.46%. Comparing base (24892e7) to head (733caf3).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
controllers/apps/configuration/config_util.go 0.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8880      +/-   ##
==========================================
+ Coverage   60.15%   60.46%   +0.30%     
==========================================
  Files         382      382              
  Lines       46331    46344      +13     
==========================================
+ Hits        27871    28021     +150     
+ Misses      15784    15650     -134     
+ Partials     2676     2673       -3     
Flag Coverage Δ
unittests 60.46% <58.82%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf force-pushed the support/config-template-empty branch from 0d2df29 to d75ffb4 Compare February 6, 2025 10:08
@leon-inf
Copy link
Contributor Author

leon-inf commented Feb 6, 2025

after overriding, we should make sure each tempatehas non-emptytemplateRef`.

Done.

@leon-inf leon-inf force-pushed the support/config-template-empty branch from d75ffb4 to 733caf3 Compare February 6, 2025 10:27
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Feb 6, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 6, 2025
@leon-inf leon-inf merged commit c29993f into main Feb 7, 2025
37 checks passed
@leon-inf leon-inf deleted the support/config-template-empty branch February 7, 2025 10:39
@leon-inf
Copy link
Contributor Author

leon-inf commented Feb 7, 2025

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/13198147911

apecloud-bot pushed a commit that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants