Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CoverM modularity into pyCoverM #2

Open
apcamargo opened this issue Dec 17, 2020 · 0 comments
Open

Implement CoverM modularity into pyCoverM #2

apcamargo opened this issue Dec 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@apcamargo
Copy link
Owner

One of the most useful things about CoverM is that it is modular, so you can determine the metrics/properties you want to compute via the --methods argument and CoverM will get them all in a single run. For example, --methods tpm covered_bases length will compute the contig (or genome) TPM, number of bases covered by reads, and reference length in a single parsing of the input BAMs.

The way pyCoverM is put together right now doesn't allow that kind of flexibility. It would require each metric to have its own function, requiring each BAM file to be parsed multiple times.

Ideally, pyCoverM would have a flexible function that takes as input all the metrics the user wants to get and it would compute them all in a single execution. Another option would be to create a class that stores all the basic information (number of reads per contig, covered bases, reference length, variance,etc.) and get the other metrics from that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant