Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #177: Consider resource manager when loading type descriptions #187

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 29, 2024

What's in the PR

  • Rename SPI class
  • Add SPI discovery file to META-INF/services (only with the 3.6.0 SPI interface, not with the legacy interfaces)

How to test manually

  • Try discovering types and JCas classes via SPI (requires classloader isolation)

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR includes new dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

@reckart reckart added the ⭐️ Enhancement New feature or request label Nov 29, 2024
@reckart reckart added this to the 3.5.0 milestone Nov 29, 2024
@reckart reckart self-assigned this Nov 29, 2024
@reckart reckart force-pushed the feature/177-Consider-resource-manager-when-loading-type-descriptions branch 2 times, most recently from 96ff4fa to 2b5e86f Compare November 29, 2024 17:43
- Rename SPI class
- Add SPI discovery file to META-INF/services (only with the 3.6.0 SPI interface, not with the legacy interfaces)
@reckart reckart force-pushed the feature/177-Consider-resource-manager-when-loading-type-descriptions branch from 2b5e86f to ead84cb Compare November 29, 2024 18:00
@reckart reckart merged commit a0b88e2 into release/3.5.x Nov 30, 2024
2 of 3 checks passed
@reckart reckart deleted the feature/177-Consider-resource-manager-when-loading-type-descriptions branch November 30, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant