-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remita-table): Extends classic table plugin with bulk actions and event publishing #32265
Open
mujibishola
wants to merge
26
commits into
apache:master
Choose a base branch
from
RemitaNet:feature/anthony/ui-fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,117
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update INTHEWILD.md
This commit refactors the table chart code by improving formatting, ensuring better compliance with coding conventions, and applying consistent indentation. It also adds type assertions, resolves styling inconsistencies, and simplifies logic for enhanced readability. No functional changes have been made.
Added explicit `width` attributes to table columns for consistent rendering and adjusted styles such as padding and overflow to enhance layout. Included tooltips for row numbers and set `tableLayout` to 'auto' for better flexibility.
Replaced `alert` with a state-driven `Alert` component for better user experience in embedded mode. The message is displayed temporarily for 5 seconds and then cleared. This enhances UX by avoiding intrusive browser alerts while maintaining visibility of the message.
…m/RemitaNet/superset into feature/anthony/ui-fixes
Added a tooltip for row numbers to enhance user experience. Introduced validation to check if actions are an array before rendering, preventing potential runtime errors. Integrated an alert message display for additional feedback.
Korbit doesn't automatically review large (3000+ lines changed) pull requests such as this one. If you want me to review anyway, use |
I gotta be honest, this PR looks pretty AI-manufactured or at least got helped out by AI big time. Un-reviewable, massive change and list-formatted PR description are one of the early caught symptoms. Please response with what you want to achieve here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
change:frontend
Requires changing the frontend
dependencies:npm
hold!
On hold
i18n
Namespace | Anything related to localization
packages
plugins
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a custom Table plugin.It provides an interface for users to add, edit, and delete custom actions that can be applied to table headers. Key features include:
Action Management:
Users can add new actions, edit existing ones, or remove them. Each action consists of properties such as a unique key, label, visibility condition, and an optional action URL (if not publishing an event).
Dual Editing Modes:
The component supports two modes for managing actions:
UI Rendering:
Actions are rendered as cards. Each card displays a header (showing the action key and control buttons for editing or deleting) and a body with additional details (using icons with tooltips to indicate the action properties).
Styling Adjustments:
The card header styling has been adjusted to match the card body’s height by using the same padding, ensuring a consistent look across the UI.
Validation:
The component includes validation rules to ensure that action keys and labels are unique.
State Management and Communication:
It manages its internal state with React hooks, and communicates changes back to the parent component via the
onChange
callback.TESTING INSTRUCTIONS
Component Rendering & Initial State:
Control Panel
component is rendered.Adding a New Action (Simple Mode):
Editing an Existing Action:
Removing an Action:
Advanced Mode (JSON Editing):
Validation Checks:
UI Consistency & Styling:
Modal Behavior:
Overall Functionality:
onChange
callback with the correct JSON string representation of the actions.ADDITIONAL INFORMATION