Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(e2e): migrate E2E testing to Playwright, phase 1 #32194

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

feat(e2e): migrate E2E testing to Playwright, phase 1 #32194

wants to merge 10 commits into from
+1,572 −0

Conversation

hainenber
Copy link
Contributor

feat(e2e): migrate E2E testing to Playwright

SUMMARY

Part of Superset megaproject to lessen pain points from existing Cypress-based E2E testing suites. This PR is 1 of many phases:

  • 1st phase: setup E2E infrastructure (config and CI) and migrate a few tests as baseline.
  • 2nd phase: migrate critical E2E tests.
  • 3rd phase: migrate the remaining ones.

I'd leave the PMCs to handle the Applitools test suites as currently I am not permitted to do so.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
feat(e2e): setup project for Playwright-based E2E testing
0cb009a 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
feat(e2e): setup CI
9c74bad 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
feat(e2): setup Playwright config and migrate some low-hanging E2E tests
23bfbea 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Feb 9, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 9, 2025
@hainenber
fix(ci): add missing license header for new files
72098ee 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): prevent ESLint running against E2E trace report generated by…
4a73f07 
… Playwright

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): fix ESLint issues
c1e88d2 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): not restore non-existent Playwright deps cache in 1st CI run
8a29d8d 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): remove caching for Playwright deps
f634290 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(ci): go into e2e directory before running tests
321f71f 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber
fix(e2e): correct expected sort value for first chart in list mode
b7387e1 
Signed-off-by: hainenber <dotronghai96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro Awaiting requested review from villebro villebro will be requested when the pull request is marked ready for review villebro is a code owner

@geido geido Awaiting requested review from geido geido will be requested when the pull request is marked ready for review geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho will be requested when the pull request is marked ready for review eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas will be requested when the pull request is marked ready for review rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida will be requested when the pull request is marked ready for review betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai will be requested when the pull request is marked ready for review nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch will be requested when the pull request is marked ready for review mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda will be requested when the pull request is marked ready for review craig-rueda is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje will be requested when the pull request is marked ready for review kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar will be requested when the pull request is marked ready for review dpgaspar is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code review:draft size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hainenber @michael-s-molina