fix(Scope): Correct issue where filters appear out of scope when sort is unchecked.

[LevisNgigi]

SUMMARY

This fixes a bug where updating a native filter will mark filters as out of scope even though they aren't.

Fixes #32014 and #32123

Fix(Scope): Correct issue where filters appear out of scope when sort is unchecked

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

1.Go to the video games dashboard
2.Edit the Genre filter by saying sort value filters by count
3.Save the filter
4.Edit the filter again and uncheck filter values and save
5.When we weren't sorted all filters were in scope, after we sorted filters are still in scope, now when you uncheck, sort filters should still be in scope.

ADDITIONAL INFORMATION

• Has associated issue: Fixes Updating a native filter will mark filters as out of scope even though they aren't #32014
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Fix Detected
	Incorrect Filter Scope Logic ▹ view	✅
	Removal of User-based Access Control Filter ▹ view	✅

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.54%. Comparing base (76d897e) to head (a926e02).
Report is 1423 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #32115      +/-   ##
==========================================
+ Coverage   60.48%   65.54%   +5.05%     
==========================================
  Files        1931      545    -1386     
  Lines       76236    38919   -37317     
  Branches     8568        0    -8568     
==========================================
- Hits        46114    25510   -20604     
+ Misses      28017    13409   -14608     
+ Partials     2105        0    -2105     

Flag	Coverage Δ
javascript	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Antonio-RiveroMartnez]

lgtm

[michael-s-molina]

@geido Can we merge this?

[github-actions]

@kgabryje Processing your ephemeral environment request here. Action: up.

[github-actions]

@kgabryje Ephemeral environment spinning up at http://35.94.61.135:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

Failing on ephemeral

[kgabryje]

Screen.Recording.2025-02-10.at.17.02.20.mov

The scoping doesn't seem to work with tabs - the range filter always appears in scope, even though it should only be active when tab2 is active

[LevisNgigi]

Screen.Recording.2025-02-10.at.17.02.20.mov
The scoping doesn't seem to work with tabs - the range filter always appears in scope, even though it should only be active when tab2 is active

Thanks for this,fixed it.