Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend list of forbidden characters in Data Explorer with "-" #2512

Closed
wants to merge 3 commits into from

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Mar 6, 2024

Purpose

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@bossenti bossenti added this to the 0.95.0 milestone Mar 6, 2024
@github-actions github-actions bot added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Mar 6, 2024
Copy link
Contributor

@tenthe tenthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check whether this will damage older installations before we merge this PR.
In particular, we need to check if the changes are in the right sanitizer. I think we should move them to the InfluxNameSanitizer. However, this has a slightly different functionality, so it needs to be customized.

To summarize:

  • We should make sure that the change does not break any old installations.
  • The runtime names of the properties must be identical in the event schema and in the event.

@bossenti
Copy link
Contributor Author

bossenti commented Mar 7, 2024

Thank you Philipp for pointing this out.

So in the end, the replacement should happen in InfluxStore.sanitizeRuntimeNamesInEvent and DataExplorerUtils.sanitizeDataLakeMeasure at the same time, right?
Then we need to adapt these methods so that they not only look for reserved keywords but also for specific characters.

Do we have a chance to introduce this not as a breaking change?

@dominikriemer
Copy link
Member

Hi
I think it's ok to rename the fields/runtime names if they are not working anyways when using a - character.
Changing the measure name is something we should avoid since there is no way in Influx to rename an existing measurement, so this would break existing measurements which are already using this character.
Using a - within a measurement name doesn't cause any problems on the writing or querying side, so there is no need to change it?

@bossenti
Copy link
Contributor Author

bossenti commented Mar 7, 2024

Using a - within a measurement name doesn't cause any problems on the writing or querying side, so there is no need to change it?

Indeed, I was on the wrong path here

@github-actions github-actions bot added the testing Relates to any kind of test (unit test, integration, or E2E test). label Mar 7, 2024
@bossenti bossenti closed this Mar 11, 2024
@bossenti bossenti deleted the fix-extend-character-blacklist-data-explorer branch March 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants