-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-51258][SQL][FOLLOWUP] Remove unnecessary inheritance from SQLC…
…onfHelper ### What changes were proposed in this pull request? This PR proposes to remove unnecessary inheritance from `SQLConfHelper`. ### Why are the changes needed? 1. There are some trait already extends `SQLConfHelper`, so we should avoid the duplicated inheritance. ``` trait TreeNodeResolver[UnresolvedNode <: TreeNode[_], ResolvedNode <: TreeNode[_]] extends SQLConfHelper with QueryErrorsBase { def resolve(unresolvedNode: UnresolvedNode): ResolvedNode } ``` ``` trait SQLHelper extends SQLConfHelper { ... } ``` ``` trait PlanTestBase extends PredicateHelper with SQLHelper { self: Suite => .. } trait PlanTest extends SparkFunSuite with PlanTestBase ``` 2. `V2SessionCatalog` already with `SQLConfHelper`, so we should use `conf` directly. ### Does this PR introduce _any_ user-facing change? 'No'. Just update the inner code. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? 'No'. Closes #50046 from beliefer/SPARK-51258_followup. Authored-by: beliefer <beliefer@163.com> Signed-off-by: beliefer <beliefer@163.com>
- Loading branch information
Showing
4 changed files
with
5 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters