Skip to content

Commit

Permalink
[SPARK-51239][INFRA] Upgrade Github Action image for `TPCDSQueryBench…
Browse files Browse the repository at this point in the history
…mark` from 20.04 to latest

### What changes were proposed in this pull request?

This PR aims to upgrade Github Action image for `TPCDSQueryBenchmark` from 20.04 to latest and update the dependency of `databricks/tpcds-kit` to the latest codes.

In the past, there were compilation problems in high-version Ubuntu images due to g++ version compatibility issues, but this problem has been solved after this PR: databricks/tpcds-kit#7

### Why are the changes needed?

Refer to: actions/runner-images#11101

> The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01

![image](https://github.com/user-attachments/assets/db68ec55-f3ca-4a24-aa81-5347c85ec0ed)

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual check on Ubuntu 24.04 and Pass GA.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #49980 from wayneguow/tpcds_inf.

Authored-by: Wei Guo <guow93@gmail.com>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
  • Loading branch information
wayneguow authored and LuciferYang committed Feb 19, 2025
1 parent b32d3f7 commit 0af25b8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
tpcds-1g-gen:
name: "Generate an input dataset for TPCDSQueryBenchmark with SF=1"
if: contains(inputs.class, 'TPCDSQueryBenchmark') || contains(inputs.class, '*')
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
env:
SPARK_LOCAL_IP: localhost
steps:
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: databricks/tpcds-kit
ref: 2a5078a782192ddb6efbcead8de9973d6ab4f069
ref: 1b7fb7529edae091684201fab142d956d6afd881
path: ./tpcds-kit
- name: Build tpcds-kit
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1028,8 +1028,7 @@ jobs:
needs: precondition
if: fromJson(needs.precondition.outputs.required).tpcds-1g == 'true'
name: Run TPC-DS queries with SF=1
# Pin to 'Ubuntu 20.04' due to 'databricks/tpcds-kit' compilation
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
timeout-minutes: 120
env:
SPARK_LOCAL_IP: localhost
Expand Down Expand Up @@ -1079,7 +1078,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: databricks/tpcds-kit
ref: 2a5078a782192ddb6efbcead8de9973d6ab4f069
ref: 1b7fb7529edae091684201fab142d956d6afd881
path: ./tpcds-kit
- name: Build tpcds-kit
if: steps.cache-tpcds-sf-1.outputs.cache-hit != 'true'
Expand Down

0 comments on commit 0af25b8

Please sign in to comment.