Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling and reporting in query side #14950

Open
2 of 9 tasks
gortiz opened this issue Jan 30, 2025 · 5 comments
Open
2 of 9 tasks

Improve error handling and reporting in query side #14950

gortiz opened this issue Jan 30, 2025 · 5 comments
Labels
multi-stage Related to the multi-stage query engine observability parent-issue query user-experience Related to user experience

Comments

@gortiz
Copy link
Contributor

gortiz commented Jan 30, 2025

Error handling and reporting can be improved in Pinot. Sometimes, error messages are not easy for users to understand, and the fact that each query engine notifies errors differently makes it even more confusing. Here is a nonexclusive list of improvements we need to apply:

@gortiz
Copy link
Contributor Author

gortiz commented Jan 30, 2025

Opened #14951 to fix the first two problems

@real-mj-song
Copy link
Contributor

MSE errors are large and don't include the actual error code. Instead, error code 200 is always returned.

💯 agreed. We definitely need a throwable/exception class containing Pinot error code info. I described the reasoning in this comment.

@vrajat
Copy link
Collaborator

vrajat commented Feb 5, 2025

MSE errors include the stack trace and don't include the actual error code. Instead, error code 200 is always returned.

This is true for SSE as well. For example:

"exceptions": [
    {
      "message": "QueryExecutionError:\nQuery execution error on: Server_100.81.71.117_7050 org.apache.pinot.spi.exception.EarlyTerminationException: Interrupted while processing next block",
      "errorCode": 200
    },

The error code should have been 503 or QUERY_CANCELLATION_ERROR_CODE

@gortiz
Copy link
Contributor Author

gortiz commented Feb 5, 2025

Please take a look at #14994

@gortiz
Copy link
Contributor Author

gortiz commented Mar 18, 2025

Correlation ID PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine observability parent-issue query user-experience Related to user experience
Projects
None yet
Development

No branches or pull requests

4 participants