Optimize closeState flag #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
requested changes
Dec 24, 2023
There was a problem hiding this comment.
I'm going to block any code change PRs that don't have descriptions. For release note and other reasons, I think any PR that changes the runtime code should have some description - we should not force users to read the code. It is not obvious to an inexperienced developer why this change is needed.
|
@pjfanning have updated |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
pjfanning
approved these changes
Dec 24, 2023
|
@jxnu-liguobin @pjfanning Should this be backport to 1.0.x too? |
|
This is not a bug fix so -1 from me for a backport. |
no need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modify the order to avoid not setting the flag when
onCompletethrows an exception.