Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-osgi to solve windows bug #1024

Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Jan 22, 2024

Resolves: #986, see sbt/sbt-osgi#115

@He-Pin

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roiocam
Copy link
Member

Roiocam commented Jan 23, 2024

LGTM

Have verified it didn't break the macOs build.

Copy link
Member

@He-Pin He-Pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.
I'm a happy Windows user now.

@mdedetrich mdedetrich merged commit 80a177b into apache:main Jan 23, 2024
18 checks passed
@mdedetrich mdedetrich deleted the update-sbt-osgi-solve-windows-bug branch January 23, 2024 05:27
@Roiocam Roiocam mentioned this pull request Jan 26, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: java.util.zip.ZipException: duplicate entry: META-INF/MANIFEST.MF in actor / osgiBundle
3 participants