Refactoring code in plugin-tester-java(scala) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laglangyue
commented
Apr 12, 2024
plugin-tester-scala/src/test/scala/example/myapp/helloworld/GreeterServiceSpec.scala
Show resolved
Hide resolved
pjfanning
requested changes
Apr 12, 2024
|
@pjfanning @He-Pin @raboof PTAL |
He-Pin
approved these changes
Apr 14, 2024
He-Pin
approved these changes
Apr 14, 2024
plugin-tester-java/src/main/java/example/myapp/helloworld/LiftedGreeterClient.java
Show resolved
Hide resolved
|
@pjfanning PTAL again. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
There are some unnecessary variable and style in
plugin-tester-Javathat does not use variables. I have readed the code for these two modules. clean up the codeplugin-tester-scala.
BTW, PowerGreeterServer and PowerGreeterServer lost the client, it will be an another PR later.
result
clean up