Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable GrpcInteropIoWithPekkoHttpJavaSpec to work #257

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Apr 6, 2024

motivation

close #204

changes

according to PekkoGrpcScalaClientTester
(1) add backend for PekkoGrpcJavaClientTester so that we can config 'pekko-http' and netty
(2) add testWithSslContext for PekkoGrpcJavaClientTester

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@laglangyue laglangyue force-pushed the enable-HttpJavaSpec branch from 57504d8 to c3fe462 Compare April 7, 2024 03:27
@laglangyue
Copy link
Contributor Author

I rebase and format the code by javafmt.
The previous CI failure was due to OOM, test it OK on my PC

Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roiocam Roiocam merged commit 0ac166c into apache:main Apr 7, 2024
19 checks passed
@laglangyue laglangyue deleted the enable-HttpJavaSpec branch April 7, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get GrpcInteropIoWithPekkoHttpJavaSpec working
4 participants