ORC-1600: Reduce getStaticMemoryManager sync block in OrcFile #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 22, 2024
### What changes were proposed in this pull request? Improve calling efficiency of `org.apache.orc.OrcFile#getStaticMemoryManager`. ### Why are the changes needed? `org.apache.orc.OrcFile#getStaticMemoryManager` is a static method with synchronized. It needs to be locked every time it is called. This is unnecessary. ### How was this patch tested? GA ### Was this patch authored or co-authored using generative AI tooling? No Closes #1768 from cxzl25/ORC-1600. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b5c2250) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thank you, @cxzl25 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve calling efficiency of
org.apache.orc.OrcFile#getStaticMemoryManager.Why are the changes needed?
org.apache.orc.OrcFile#getStaticMemoryManageris a static method with synchronized. It needs to be locked every time it is called. This is unnecessary.How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No