Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1100: Add vcpkg release document #1746

Closed
wants to merge 2 commits into from
Closed

ORC-1100: Add vcpkg release document #1746

wants to merge 2 commits into from

Conversation

deshanxiao
Copy link
Contributor

What changes were proposed in this pull request?

This PR is aimed to add vcpkg document to note how to update vcpkg package when we release a new version.

Why are the changes needed?

To help release manager to release our latest package in vcpkg.

How was this patch tested?

N/A

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Jan 12, 2024
@deshanxiao
Copy link
Contributor Author

cc @dongjoon-hyun @wgtmac


> Expected hash: 141afbd6d83b8c8032df071838e7da61eedb3d22289642f76669b6efd167d7550b200bd3542f012d0b63c9ae2572d83fcb1b7f76537b6fa6f980aebf37e2cde2

> Actual hash (you should update): 7b9d6f9613f48b41843618465c0c71ed70e5695b4fc4b3db15d0bbfe4c5126e0c6c8f1114d6c450a56b4ddf0357d89bd40cb03c0964275c59761cc0f8fec1291
Copy link
Contributor

@paliwalashish paliwalashish Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the actual hash a constant value or we get it from somewhere?

Don't know much about vcpkg

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR with the example, @deshanxiao .

The SHA512 value is provided by Apache ORC community like the following.

7f46f2c184ecefd6791f1a53fb062286818bd8710c3f08b94dd3cac365e240ee

Do you mean to use the error message recommended value, Expected hash, in the PR?

@deshanxiao
Copy link
Contributor Author

@dongjoon-hyun yes, I got the hash from the error message. From the vcpkg document, it recommand us to update it to zero and get the hash from error message too.

@deshanxiao
Copy link
Contributor Author

For orc 1.9.2:

141afbd6d83b8c8032df071838e7da61eedb3d22289642f76669b6efd167d7550b200bd3542f012d0b63c9ae2572d83fcb1b7f76537b6fa6f980aebf37e2cde2

dongjoon-hyun pushed a commit that referenced this pull request Jan 13, 2024
### What changes were proposed in this pull request?
This PR is aimed to add vcpkg document to note how to update vcpkg package when we release a new version.

### Why are the changes needed?
To help release manager to release our latest package in vcpkg.

### How was this patch tested?
N/A

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1746 from deshanxiao/deshan/update-doc.

Authored-by: deshanxiao <deshanxiao@microsoft.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit c87707c)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Jan 13, 2024
@dongjoon-hyun
Copy link
Member

Thank you, @deshanxiao and all.

Merged to main/2.0. We can revise it later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants