Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1584: Remove proto from README.md #1744

Closed
wants to merge 1 commit into from
Closed

Conversation

cxzl25
Copy link
Contributor

@cxzl25 cxzl25 commented Jan 11, 2024

What changes were proposed in this pull request?

Delete proto subdirectory description.

Why are the changes needed?

We have moved to orc-format project.

How was this patch tested?

GA

Was this patch authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the DOCS label Jan 11, 2024
@dongjoon-hyun dongjoon-hyun changed the title ORC-1584: Remove Readme about Proto subdirectory ORC-1584: Remove photo from README.md Jan 11, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you for this cleanup, @cxzl25 .

@dongjoon-hyun dongjoon-hyun changed the title ORC-1584: Remove photo from README.md ORC-1584: Remove proto from README.md Jan 11, 2024
@dongjoon-hyun dongjoon-hyun changed the title ORC-1584: Remove proto from README.md ORC-1584: Remove proto from README.md Jan 11, 2024
dongjoon-hyun pushed a commit that referenced this pull request Jan 11, 2024
### What changes were proposed in this pull request?
Delete proto subdirectory description.

### Why are the changes needed?
We have moved to [orc-format](https://github.com/apache/orc-format) project.

### How was this patch tested?
GA

### Was this patch authored or co-authored using generative AI tooling?
No

Closes #1744 from cxzl25/ORC-1584.

Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 988b98c)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member

Merged to main/2.0.

@dongjoon-hyun dongjoon-hyun added this to the 2.0.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants