Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
### What changes were proposed in this pull request? This PR aims to use legacy `readDiskRanges` method if `orc.use.zerocopy` is enabled. ### Why are the changes needed? Since `orc.use.zerocopy` is disabled by default, Apache ORC will use `Vectored IO` still after this PR. The main background of this PR is that we had better keep the original behavior until Apache ORC take advantages of new `Vectored IO` API with ZeroCopy code path. We can improve later at Apache ORC 2.1.x. Note that `ZeroCopy` reader is known to be used by `Apache Hive LLAP` (`LlapOrcCacheLoader`, `LlapRecordReaderUtil`, `OrcEncodedDataReader`) like the following. However, `Apache Hive 4.0.0` is incompatible with Apache ORC 2.0.0 because it still requires Java 8 minimum support. - https://github.com/apache/hive/blob/b33b3d3454cc9c65a1879c68679f33f207f21c0e/llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/LlapOrcCacheLoader.java#L92 ```java boolean useZeroCopy = (daemonConf != null) && OrcConf.USE_ZEROCOPY.getBoolean(daemonConf); ``` ### How was this patch tested? Pass the CIs. Closes #1723 from dongjoon-hyun/ORC-1568. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
- Loading branch information