Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building the cli on pull request #86

Open
sciabarracom opened this issue Dec 14, 2024 · 1 comment
Open

Add support for building the cli on pull request #86

sciabarracom opened this issue Dec 14, 2024 · 1 comment

Comments

@sciabarracom
Copy link
Contributor

Why you need it?

To build the cli when someone contributes a PR and it is accepted.

How it could be?

A "contrib" workflow in github.com/apache/openserverless-cli that

  • createa a tag from the version.txt
  • trigger a build and a release using the release workflow

Other related information

A partial implementation creating the tag when someone contribute a PR is already available.
However looks like it does not trigger another build for some reasons.
We shoulud either add the trigger or merge the code with the release workflow so it is activated both by pr AND pull requests.

@sciabarracom
Copy link
Contributor Author

Also add to the README the documentation how to contribute a PR.
Basically all it is needed is to run task tag before contributing will generate a new tag and update the version.txt used by the buid.
Once the version.txt is updated this workflow will propagate the version.txt as a tag and the go releases can build with the right version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant