Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Smetana for generating puml, fix comments syntax #676

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Feb 8, 2025

No description provided.

@slawekjaranowski slawekjaranowski marked this pull request as draft February 8, 2025 16:18
@slawekjaranowski slawekjaranowski requested a review from kwin February 8, 2025 16:19
@slawekjaranowski slawekjaranowski marked this pull request as ready for review February 8, 2025 16:36
@kwin
Copy link
Member

kwin commented Feb 8, 2025

Maybe the wrong comment syntax (https://plantuml.com/commons#8413c683b4b27cc3) is to blame here.

@slawekjaranowski
Copy link
Member Author

@kwin comments fixed ... exception still exists

@kwin
Copy link
Member

kwin commented Feb 8, 2025

Yes, I am out of ideas here. Still let us commit these changes, they are valid anyhow...

@slawekjaranowski slawekjaranowski changed the title Use Smetana for generating puml Use Smetana for generating puml, fix comments syntax Feb 8, 2025
@slawekjaranowski slawekjaranowski merged commit ba1d1d9 into apache:master Feb 8, 2025
1 check passed
@slawekjaranowski slawekjaranowski deleted the use-smetana branch February 8, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants