Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNGSITE-393] Repository layout hasn't changed since Maven 2 #667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 5, 2025

@elharo elharo requested a review from hboutemy February 5, 2025 20:39
@elharo elharo marked this pull request as ready for review February 5, 2025 23:29
@hboutemy
Copy link
Member

hboutemy commented Feb 5, 2025

i don't get what we win by hiding history of Maven 1 and 2

@elharo
Copy link
Contributor Author

elharo commented Feb 5, 2025

Consider the audience. Anyone coming to this page wants to know the current info, not what happened 10+ years ago that is no longer in production anywhere.

@hboutemy
Copy link
Member

hboutemy commented Feb 7, 2025

on many pages about build aspects of Maven, I agree to dropping complexity on usual audience

on repository format layout https://maven.apache.org/repository/layout.html , I really think it is really important to keep that small note about format for 1 vs format for 2+

please don't remove this one

@@ -19,7 +19,9 @@ specific language governing permissions and limitations
under the License.
-->

Maven2 repository layout format is the default layout used since Maven 2 (see [Repository Layout- Final](https://cwiki.apache.org/confluence/display/MAVENOLD/Repository+Layout+-+Final) in [Maven 2.0 Design Documents](https://cwiki.apache.org/confluence/display/MAVENOLD/Maven+2.0+Design+Documents)), superceding old Maven 1 layout:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps even adding a link to Maven Central for Maven 1 http://repo1.maven.org/maven/
vs Maven Central for Maven 2 https://repo1.maven.org/maven2/
could help make the 2 very concrete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know anyone still using Maven 1? (I find it ironic that in one PR I'm arguing against requiring Java 17 instead of Java 8, and in another I'm arguing to drop Maven 1.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also your Maven 1 link doesn't work.

501 HTTPS Required.
Use https://repo1.maven.org/maven2/
More information at https://links.sonatype.com/central/501-https-required

Neither does https://repo1.maven.org/maven/ which is 404.

That's good evidence that Maven 1 is dead and can now be ignored.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see: not listening

I won't discuss, seems to be lost time: just clarifying that I veto this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants