Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub issues - release vote #641

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

slawekjaranowski
Copy link
Member

No description provided.

@slawekjaranowski slawekjaranowski added enhancement New feature or request maintenance and removed enhancement New feature or request labels Jan 11, 2025
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.

To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.

** GitHub issues

We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean by "left issues". Unfinished issues maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a text:

There are still a couple of issues left in JIRA:

so I follow what we have

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to quote this directly. "left" as an adjective is a little weird. When it precedes the noun, it almost always refers to the left hand side, and not to things left behind. If we want to indicate that something was left behind we'd follow the noun. That is, we'd say "The people left when the plane took off" and not "The left people when the plane took off". I'm guessing this is one of those weird rules of English native speakers don't think about. I never noticed it until just now.

Maybe something like

We link to the for issues resolved in the release, and link to for issues that are still open

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elharo fixed as proposed

To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.

To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.

** GitHub issues

We link to the <GitHub milestone> for issues resolved in the release, and link to <GitHub issues> for issues that are still open
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: colon or period at end of sentence

@slawekjaranowski slawekjaranowski merged commit 21a2012 into apache:master Jan 13, 2025
1 check passed
@slawekjaranowski slawekjaranowski deleted the rel-notes-gh branch January 13, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants