-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub issues - release vote #641
Conversation
content/apt/developers/release/maven-project-release-procedure.apt
Outdated
Show resolved
Hide resolved
4609a63
to
7ec21bc
Compare
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version, | ||
and use the link to <Release Notes> that is next to the version being released. | ||
|
||
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters> | ||
on the right, use the link for <Outstanding> issues. | ||
|
||
** GitHub issues | ||
|
||
We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean by "left issues". Unfinished issues maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a text:
There are still a couple of issues left in JIRA:
so I follow what we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to quote this directly. "left" as an adjective is a little weird. When it precedes the noun, it almost always refers to the left hand side, and not to things left behind. If we want to indicate that something was left behind we'd follow the noun. That is, we'd say "The people left when the plane took off" and not "The left people when the plane took off". I'm guessing this is one of those weird rules of English native speakers don't think about. I never noticed it until just now.
Maybe something like
We link to the for issues resolved in the release, and link to for issues that are still open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elharo fixed as proposed
7ec21bc
to
8d8bda9
Compare
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version, | ||
and use the link to <Release Notes> that is next to the version being released. | ||
|
||
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters> | ||
on the right, use the link for <Outstanding> issues. | ||
|
||
** GitHub issues | ||
|
||
We link to the <GitHub milestone> for issues resolved in the release, and link to <GitHub issues> for issues that are still open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: colon or period at end of sentence
8d8bda9
to
12d02d7
Compare
No description provided.