KAFKA-19042: [5/N] Move PlaintextConsumerCommitTest to client-integration-tests module #19389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
|
|
||
| private void sendAndAwaitAsyncCommit( | ||
| Consumer<byte[], byte[]> consumer, | ||
| Optional<Map<TopicPartition, OffsetAndMetadata>> offsetsOpt |
There was a problem hiding this comment.
It looks like all offsetOpt input is not empty. Do you think that we can remove Optional<> from sendAndAwaitAsyncCommit and RetryCommitCallback?
| Topic.GROUP_METADATA_TOPIC_NAME, | ||
| Integer.parseInt(OFFSETS_TOPIC_PARTITIONS), | ||
| Short.parseShort(OFFSETS_TOPIC_REPLICATION) | ||
| ); |
There was a problem hiding this comment.
Could you add some comments about why we need to manually create internal topic here? It looks like we don't set AUTO_CREATE_TOPICS_ENABLE_CONFIG as false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Java to rewrite
PlaintextConsumerCommitTestby new test infra andmove it to client-integration-tests module.