KAFKA-19093: Change the "Handler on Broker" to "Handler on Controller" for controller server #19384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" for controller server
github-actions
bot
added
triage
m1a2st
reviewed
Apr 5, 2025
| @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( | |||
| /* a meter to track the average free capacity of the request handlers */ | |||
| private val aggregateIdleMeter = metricsGroup.newMeter(requestHandlerAvgIdleMetricName, "percent", TimeUnit.NANOSECONDS) | |||
|
|
|||
| this.logIdent = "[" + logAndThreadNamePrefix + " Kafka Request Handler on Broker " + brokerId + "], " | |||
| this.logIdent = "[" + logAndThreadNamePrefix + " Kafka Request Handler on Controller " + brokerId + "], " | |||
There was a problem hiding this comment.
I think that we should use ${nodeName.capitalize} instead of hard core, WDYT?
There was a problem hiding this comment.
You're right,I completely agree with your suggestion.Thanks for catching this! Fixed it.
m1a2st
approved these changes
Apr 6, 2025
chia7712
reviewed
Apr 8, 2025
| @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( | |||
| /* a meter to track the average free capacity of the request handlers */ | |||
| private val aggregateIdleMeter = metricsGroup.newMeter(requestHandlerAvgIdleMetricName, "percent", TimeUnit.NANOSECONDS) | |||
|
|
|||
| this.logIdent = "[" + logAndThreadNamePrefix + " Kafka Request Handler on Broker " + brokerId + "], " | |||
| this.logIdent = s"[$logAndThreadNamePrefix Kafka Request Handler on ${nodeName.capitalize} $brokerId], " | |||
There was a problem hiding this comment.
Maybe we can remove the ",". it is a bit weird to me, WDYT?
There was a problem hiding this comment.
Thanks for the suggestion! Removed it.
chia7712
reviewed
Apr 8, 2025
Removed it. |
chia7712
approved these changes
Apr 9, 2025
|
the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-7542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/KAFKA-19093
it should be "Controller" rather than "Broker"
Reviewers: Ken Huang s7133700@gmail.com, Chia-Ping Tsai
chia7712@gmail.com