-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Cleanup Core Module- Scala Modules (1/n) #19380
base: trunk
Are you sure you want to change the base?
Conversation
OffloadAndTxnConsumeFromLeaderTest -> Seems to be a flaky test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sjhajharia, Thanks for this PR. I found there are some Collections
related not modified on your branch. Could you take a look.
Hey @m1a2st |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sjhajharia for this patch, left some comments.
Could you check all scala code which use asJava
to transfer Scala collection to Java collection, We can avoid to use both collection in same file.
And also update util.Arrays.asList
to java.util.List.of
.
Thanks @m1a2st for the comment. To be clear, the directories being targeted in this PR are:
|
Now that Kafka Brokers support Java 17, this PR makes some changes in
core module. The changes in this PR are limited to only the Scala files
in the Core module's tests. The unit tests module is still pending. It
shall follow next. The changes mostly include:
Arrays.asList() are replaced with List.of()
with Map.of()
To be clear, the directories being targeted in this PR are: