-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-19080 The constraint on segment.ms is not enforced at topic level #19371
base: trunk
Are you sure you want to change the base?
Conversation
Hello @junrao, @chia7712 I think there are two possible approaches to resolve this:
|
@m1a2st : Perhaps we could somehow allow the tests to set a small |
Maybe we can add a internal config to allow tests to define small size? |
for example: this.internalSegmentSize = getString(TopicConfig.INTERNAL_SEGMENT_BYTES_CONFIG);
...
public long segmentSize() {
if (internalSegmentSize != null) return Long.parseLong(internalSegmentSize);
return segmentMs;
} |
The main reason is that we forgot setting the
TopicConfig.SEGMENT_BYTES_CONFIG
at least to1024 * 1024
, thusaddressed it, and add a test for it.