KAFKA-15370: ACL changes to support 2PC (KIP-939) #19364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
There was a problem hiding this comment.
Leave a minor comment. Please fix the failed case. Thanks.
@ParameterizedTest
@ValueSource(strings = Array(KRAFT))
def testAclInheritance(quorum: String): Unit = {
testImplicationsOfAllow(AclOperation.ALL, Set(READ, WRITE, CREATE, DELETE, ALTER, DESCRIBE,
CLUSTER_ACTION, DESCRIBE_CONFIGS, ALTER_CONFIGS, IDEMPOTENT_WRITE, CREATE_TOKENS, DESCRIBE_TOKENS, TWO_PHASE_COMMIT))
testImplicationsOfDeny(AclOperation.ALL, Set(READ, WRITE, CREATE, DELETE, ALTER, DESCRIBE,
CLUSTER_ACTION, DESCRIBE_CONFIGS, ALTER_CONFIGS, IDEMPOTENT_WRITE, CREATE_TOKENS, DESCRIBE_TOKENS, TWO_PHASE_COMMIT))
testImplicationsOfAllow(READ, Set(DESCRIBE))
testImplicationsOfAllow(WRITE, Set(DESCRIBE))
testImplicationsOfAllow(DELETE, Set(DESCRIBE))
testImplicationsOfAllow(ALTER, Set(DESCRIBE))
testImplicationsOfDeny(DESCRIBE, Set())
testImplicationsOfAllow(ALTER_CONFIGS, Set(DESCRIBE_CONFIGS))
testImplicationsOfDeny(DESCRIBE_CONFIGS, Set())
}| @@ -1520,6 +1520,10 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| requestHelper.sendErrorResponseMaybeThrottle(request, Errors.TRANSACTIONAL_ID_AUTHORIZATION_FAILED.exception) | |||
| return | |||
| } | |||
| if (initProducerIdRequest.enable2Pc() && !authHelper.authorize(request.context, TWO_PHASE_COMMIT, TRANSACTIONAL_ID, transactionalId)) { | |||
| requestHelper.sendErrorResponseMaybeThrottle(request, Errors.TRANSACTIONAL_ID_AUTHORIZATION_FAILED.exception) | |||
There was a problem hiding this comment.
The TRANSACTIONAL_ID_AUTHORIZATION_FAILED is returned when client lacks either WRITE or TWO_PHASE_COMMIT permissions. Should we include information about which specific permission needs to be granted to the user in order to complete the operation?
There was a problem hiding this comment.
Hey, thanks for the comment! I'm unsure if exposing the exact missing ACL is common practice. Let me double-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds ACL support for 2PC as a part of KIP-939
A new value will be added to the enum AclOperation: TWO_PHASE_COMMIT ((byte) 15 . When InitProducerId comes with enable2Pc=true, it would have to have both WRITE and TWO_PHASE_COMMIT operation enabled on the transactional id resource.
The kafka-acls.sh tool is going to support a new --operation TwoPhaseCommit.