[#4024]Refactor: Reduce unnecessary queries in catalog JDBC implementation #6540
+114
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Feb 26, 2025
| + " AND mm.deleted_at = 0 AND cm.deleted_at = 0"; | ||
| } | ||
|
|
||
| public String listCatalogPOsByCatalogName(@Param("catalogName") String catalogName) { |
There was a problem hiding this comment.
Is there a scenario which we need to get all catalogs with the name catalogName in all metalakes?
zzzk1
commented
Feb 26, 2025
Comment on lines
130
to
142
| if (namespace.levels().length >= 2) { | ||
| catalogPOS = | ||
| SessionUtils.getWithoutCommit( | ||
| CatalogMetaMapper.class, | ||
| mapper -> mapper.listCatalogPOsByCatalogName(namespace.level(1))); | ||
| } | ||
|
|
||
| Long metalakeId = CommonMetaService.getInstance().getParentEntityIdByNamespace(namespace); | ||
|
|
||
| List<CatalogPO> catalogPOS = | ||
| SessionUtils.getWithoutCommit( | ||
| CatalogMetaMapper.class, mapper -> mapper.listCatalogPOsByMetalakeId(metalakeId)); | ||
| if (namespace.levels().length >= 3) { | ||
| catalogPOS = | ||
| SessionUtils.getWithoutCommit( | ||
| CatalogMetaMapper.class, | ||
| mapper -> mapper.listCatalogPOsBySchemaName(namespace.level(2))); | ||
| } |
There was a problem hiding this comment.
Mistakes here right？metalake has many catalogs, catalog has many schema. level-1 needs metalake name catalog name, level-2 needs metalake name catalog name schema name.
|
Maybe I have found the reason: currently, the IT test only contains level-0 conditions. That is why the incorrect refactor still passes CI. |
zzzk1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For queries involving more related tables, use a JOIN operation instead of executing separate queries to retrieve the results.
Why are the changes needed?
There are many unnecessary query operations, and the two tables can be directly associated to reduce these operations.
Part of: #4024
Does this PR introduce any user-facing change?
no
How was this patch tested?
unit tests & backend intergation tests