[#6537] improvement(core): Change the level of some log in LockManager and GarbageCollector from INFO to DEBUG
#6539
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from info to debug to reduce log.
jerqi
changed the title
LockManager and GrabageCollector from INFO to DEBUG LockManager and GarbageCollector from INFO to DEBUG
jerqi
reviewed
Feb 26, 2025
| // If the total node count is greater than the maxTreeNodeInMemory * 0.5, we will do the | ||
| // clear up in case of the memory explosion. | ||
| if (nodeCount > maxTreeNodeInMemory * 0.5) { | ||
| StopWatch watch = StopWatch.createStarted(); | ||
| LOG.trace("Start to clean up the stale tree lock nodes..."); | ||
| LOG.info("Start to clean up the stale tree lock nodes..."); |
There was a problem hiding this comment.
This line will be printed only when nodeCount > maxTreeNodeInMemory * 0.5; in this case, we did need to give the user some information.
jerryshao
approved these changes
Feb 26, 2025
|
nice cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the level of log from INFO to DEBUG.
Why are the changes needed?
As the log will be show periodically, in order to reduce the size of the Gravitino server log, we need to change it from INFO to DEBUG.
Fix: #6537
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Existing UTs and ITs.