[#6523] fix(core): Filter null prop when init properties #6524
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because this is a bug fix. Could you add a UT to cover this change? |
OK |
tengqm
reviewed
Feb 26, 2025
| @@ -77,6 +77,7 @@ public String storageLocation() { | |||
| public Map<String, String> properties() { | |||
| return fileset.properties().entrySet().stream() | |||
| .filter(p -> !hiddenProperties.contains(p.getKey())) | |||
| .filter(entry -> entry.getKey() != null && entry.getValue() != null) | |||
There was a problem hiding this comment.
how could entry.getKey() becomes null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Filters out any entries with null keys/values before collection, to prevent potential NullPointerExceptions when accessing entries
Why are the changes needed?
Due to the cancellation of the operation to reload the topic to fill in its other properties after the alter operation in #3729, there is a risk that the value of the downstream property may return null, which in turn could trigger a NullPointerException in the properties() method of the Topic class.
Fix: #6523
Does this PR introduce any user-facing change?
no
How was this patch tested?
no need to add test