-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6399] Added validation to fileset dialog #6400
Conversation
Thanks for your PR! Could you plz follow the format like other PR titles? |
done, please could you check now? |
plz make the CI pass. see: https://github.com/apache/gravitino/actions/runs/13173847662/job/36768887540?pr=6400 |
There's some formatting issue with your PR, to make the tests pass you'll need to run prettier with --write to format the code correctly. |
@justinmclean Thanks for the heads-up! I ran Prettier with --write, and the formatting should be correct now. Let me know if anything else needs fixing |
@mchades CI has been passed |
@LauraXia123 , can you please help to review this PR? |
@Pranaykarvi Hi,you can update the |
@LauraXia123 I made the changes in the regex file |
I read the |
@Pranaykarvi Hi, can you run prettier to fix formatting? |
@LauraXia123 done please could you check now? |
@Pranaykarvi @LauraXia123 can you please check build error here? |
@Pranaykarvi can you run |
@jerryshao @LauraXia123 |
@jerryshao passed can u check now? |
@Pranaykarvi Hi, the nameRegex rules should be consistent with the back end |
lgtm |
@Pranaykarvi can you please address the comments mentioned by @LauraXia123 ? If you don't have time, we can help to continue on this PR, thanks. |
@jerryshao @LauraXia123 i have made the changes now can you check? |
Co-authored-by: Qian Xia <lauraxiaqian@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@jerryshao @mchades I’ve made the requested changes, and @LauraXia123 has approved them. Could you please review the PR and, if everything looks good, proceed with merging? Thanks! |
### What changes were proposed in this pull request? The validation schema for the `key` field within the `propItems` array was modified to allow hyphens in file names. The regular expression for the `key` was updated to: ```js /^[a-zA-Z_][a-zA-Z0-9_-]*$/ ``` ### Why are the changes needed? Fix: issue #6399 The UI was incorrectly rejecting file names containing hyphens when creating a fileset, even though hyphens were allowed in the name specification. The changes ensure that hyphens are properly validated as part of the file name. ### Does this PR introduce any user-facing change? Yes, this PR allows users to use hyphens in file names when creating a files ### How was this patch tested? The changes were tested by creating filesets with hyphens in the names via the UI, ensuring they were accepted correctly. --------- Co-authored-by: Qian Xia <lauraxiaqian@gmail.com>
What changes were proposed in this pull request?
The validation schema for the
key
field within thepropItems
array was modified to allow hyphens in file names. The regular expression for thekey
was updated to:/^[a-zA-Z_][a-zA-Z0-9_-]*$/
Why are the changes needed?
Fix: issue #6399
The UI was incorrectly rejecting file names containing hyphens when creating a fileset, even though hyphens were allowed in the name specification. The changes ensure that hyphens are properly validated as part of the file name.
Does this PR introduce any user-facing change?
Yes, this PR allows users to use hyphens in file names when creating a files
How was this patch tested?
The changes were tested by creating filesets with hyphens in the names via the UI, ensuring they were accepted correctly.