Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Hyphen (-) should be supported in model names #6544

Open
JunpingDu opened this issue Feb 26, 2025 · 0 comments
Open

[Bug report] Hyphen (-) should be supported in model names #6544

JunpingDu opened this issue Feb 26, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JunpingDu
Copy link
Contributor

Version

main branch

Describe what's wrong

When you try to add a new model, such as deepseek-r1, it will report an issue with illegal name XXX. I think we should support Hyphen(-) in model registration for the convenience of usage.

Image

Error message and/or stacktrace

Something like "the catalog name XXX is illegal" in UI page

How to reproduce

In page of create catalog, put something like "DeepSeek-R1", you will see that.

Additional context

No response

@JunpingDu JunpingDu added bug Something isn't working good first issue Good for newcomers labels Feb 26, 2025
@JunpingDu JunpingDu changed the title [Bug report] Hyphen (-) should be support in model names [Bug report] Hyphen (-) should be supported in model names Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant