Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In IcebergTableRenameOperations.java wrong logging class is used #6518

Closed
justinmclean opened this issue Feb 25, 2025 · 2 comments
Closed

[Improvement] In IcebergTableRenameOperations.java wrong logging class is used #6518

justinmclean opened this issue Feb 25, 2025 · 2 comments
Assignees
@Brijeshthummar02
Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

This line uses the incorrect class:
private static final Logger LOG = LoggerFactory.getLogger(IcebergTableOperations.class);

How should we improve?

Use the correct class.
@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Feb 25, 2025
@Kes104
Copy link

Kes104 commented Feb 25, 2025

Hello @justinmclean I am interested to contribute to this issue. Can you help me with it ? (Like what's the expected Class which has to be called)

@Brijeshthummar02
Copy link
Contributor

@justinmclean on my way to open PR!

@Brijeshthummar02 Brijeshthummar02 mentioned this issue Feb 25, 2025
Merged
justinmclean pushed a commit that referenced this issue Feb 26, 2025
@Brijeshthummar02
fix(logging): Correct logger class in IcebergTableRenameOperations (#…
d36ebac 
…6522)

### What changes were proposed in this pull request?

Fixed an incorrect logging class reference in
IcebergTableRenameOperations.

### Why are the changes needed?

The logger was incorrectly referencing IcebergTableOperations instead of
IcebergTableRenameOperations, which could cause confusion in logs.

Fix: #6518 


### Does this PR introduce *any* user-facing change?

No

### How was this patch tested?

No testing is required.
@jerryshao jerryshao added the 0.9.0 Release v0.9.0 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Brijeshthummar02 Brijeshthummar02

Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinmclean @jerryshao @Brijeshthummar02 @Kes104