Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] In UntagEntity.java unneeded call to toString() #6517

Closed
justinmclean opened this issue Feb 25, 2025 · 6 comments · Fixed by #6521
Closed

[Improvement] In UntagEntity.java unneeded call to toString() #6517

justinmclean opened this issue Feb 25, 2025 · 6 comments · Fixed by #6521
Assignees
@JavedAbdullah
Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

As tags is an array of strings, tags[0].toString() doesn't require toString().

How should we improve?

Remove toString() call.
@justinmclean justinmclean added improvement Improvements on everything good first issue Good for newcomers labels Feb 25, 2025
@Brijeshthummar02
Copy link
Contributor

@justinmclean assign me i will do it.

JavedAbdullah added a commit to JavedAbdullah/gravitino that referenced this issue Feb 25, 2025
@JavedAbdullah
fix: unneeded call to toString() (closes apache#6517)
21ba419
@JavedAbdullah JavedAbdullah mentioned this issue Feb 25, 2025
Merged
@JavedAbdullah
Copy link
Contributor

I've fixed this issue, sorry, I hadn't seen the comment.

@Brijeshthummar02
Copy link
Contributor

@JavedAbdullah i was just pushing the PR and u submitted it.

@JavedAbdullah
Copy link
Contributor

@JavedAbdullah i was just pushing the PR and u submitted it.

Sorry, this was my first open-source contribution. I was working on it and didn’t see the comment.

@justinmclean
Copy link
Member Author

@Brijeshthummar02, we have other issues marked good first issue https://github.com/apache/gravitino/contribute. You can select one of those. I'll also add some more tomorrow that will be easy to fix.

@Brijeshthummar02
Copy link
Contributor

@justinmclean Sure i will keep eye on it and try to fix as many as possible, it just boosts my Open Source work!

justinmclean pushed a commit that referenced this issue Feb 25, 2025
@JavedAbdullah
[#6517] fix: unneeded call to toString() (#6521)
f39f4d4 
### What changes were proposed in this pull request?

As tags is an array of strings, `tags[0].toString()` doesn't require
`toString()`.

### Why are the changes needed?

to string method not needed.

Fix: #6517 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

no needed
@jerryshao jerryshao added the 0.9.0 Release v0.9.0 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JavedAbdullah JavedAbdullah

Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6517] fix: unneeded call to toString() JavedAbdullah/gravitino
4 participants
@justinmclean @jerryshao @JavedAbdullah @Brijeshthummar02