Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Missing @Override in SchemaMetaPostgreSQLProvider.java #6516

Closed
justinmclean opened this issue Feb 25, 2025 · 1 comment · Fixed by #6520
Closed

[Improvement] Missing @Override in SchemaMetaPostgreSQLProvider.java #6516

justinmclean opened this issue Feb 25, 2025 · 1 comment · Fixed by #6520
Assignees
@AndreVale69
Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

justinmclean commented Feb 25, 2025 •
edited
Loading

What would you like to be improved?

Method deleteSchemaMetasByLegacyTimeline is missing the override annotation.

How should we improve?

Add the annotation.
@justinmclean justinmclean added improvement Improvements on everything good first issue Good for newcomers labels Feb 25, 2025
@AndreVale69 AndreVale69 mentioned this issue Feb 25, 2025
Merged
@AndreVale69
Copy link
Contributor

Hi, I've solved this issue on the PR #6520

jerryshao pushed a commit that referenced this issue Feb 25, 2025
@AndreVale69
[#6516] fix: add @OverRide annotation (#6520)
ce5fd51 
### What changes were proposed in this pull request?

The method `deleteSchemaMetasByLegacyTimeline`
([SchemaMetaPostgreSQLProvider.java](https://github.com/apache/gravitino/blob/4996d0c50e64fc9a702117a4ded1451867d7b89b/core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/postgresql/SchemaMetaPostgreSQLProvider.java#L86))
was missing the `@Override` annotation.

### Why are the changes needed?

Method `deleteSchemaMetasByLegacyTimeline` is missing the override
annotation.

Fix: #6516 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No testing is required.
@jerryshao jerryshao added the 0.9.0 Release v0.9.0 label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreVale69 AndreVale69

Labels
0.9.0 Release v0.9.0 good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6516] fix: add @Override annotation AndreVale69/gravitino
3 participants
@justinmclean @jerryshao @AndreVale69