Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Possible resource leak in BaseCatalog.java #6513

Open
justinmclean opened this issue Feb 25, 2025 · 7 comments
Open

[Improvement] Possible resource leak in BaseCatalog.java #6513

justinmclean opened this issue Feb 25, 2025 · 7 comments
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

This code:
BaseAuthorization<?> authorization =
BaseAuthorization.createAuthorization(classLoader, authorizationProvider);

This probably needs to be closed if an exception occurs?

How should we improve?

No response

@justinmclean justinmclean added improvement Improvements on everything good first issue Good for newcomers labels Feb 25, 2025
@Brijeshthummar02
Copy link
Contributor

@justinmclean can u provide path to the file i will fix it!

@justinmclean
Copy link
Member Author

core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java

@justinmclean
Copy link
Member Author

@Brijeshthummar02 I saw you closed your PR. Do you still want to work on this issue?

@Brijeshthummar02
Copy link
Contributor

@justinmclean yes i am trying to make new clone and fix it, when i deleted the fork it by default closed PR. I am working on it.

@justinmclean
Copy link
Member Author

Excellent, if you run into any issues I'll try to help.

@Brijeshthummar02
Copy link
Contributor

@justinmclean there are multiple BaseCatalog.java provide the file to path

Image

@justinmclean
Copy link
Member Author

justinmclean commented Feb 26, 2025

The one you want is core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants