Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Backend storage repeatedly restarts in a UT class. #6505

Open
mchades opened this issue Feb 25, 2025 · 0 comments
Open

[Improvement] Backend storage repeatedly restarts in a UT class. #6505

mchades opened this issue Feb 25, 2025 · 0 comments
Assignees
Labels
improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Feb 25, 2025

What would you like to be improved?

in the test class, each UT will restart H2, MySQL, and PostgreSQL, which is unnecessary but also causes tests to slow since they need to start and stop the container repeatedly.

static Object[] storageProvider() {
return new Object[] {"h2", "mysql", "postgresql"};
}
@AfterEach
void closeSuit() throws IOException {
ContainerSuite.getInstance().close();
}

How should we improve?

reuse the backend storage instance in the class

@mchades mchades added the improvement Improvements on everything label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants