Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] support different Docker versions for integration tests #6491

Open
youngyjd opened this issue Feb 20, 2025 · 2 comments
Open
Labels
improvement Improvements on everything

Comments

@youngyjd
Copy link

What would you like to be improved?

  1. List what docker versions are required to run the integration tests.
  2. Support Docker version < 20.10+ if possible. Our CI runs Docker version 19.03.15 that does not have host-gateway feature required in trino integration test -
    - "host.docker.internal:host-gateway"
  3. Support Compose V1 if possible. Our CI runs Compose V1. docker compose up -d errored out in our CI pipeline.

For 3, I managed to bypass it by installing Compose V2 through

mkdir -p ~/.docker/cli-plugins/
curl -SL https://github.com/docker/compose/releases/latest/download/docker-compose-linux-x86_64 -o ~/.docker/cli-plugins/docker-compose
chmod +x ~/.docker/cli-plugins/docker-compose

For 2, it is harder since our CI user does not have sudo access. While I am working with our CI team to find a solution, is there any plan to have the integration tests compatible with older version Docker?

How should we improve?

No response

@youngyjd youngyjd added the improvement Improvements on everything label Feb 20, 2025
@youngyjd youngyjd changed the title [Improvement] Docker version [Improvement] support different Docker versions for integration tests Feb 20, 2025
@youngyjd
Copy link
Author

Seems there is a potential solution for older version Docker? docker/cli#2664

@tengqm
Copy link
Contributor

tengqm commented Feb 20, 2025

I'm wondering if we should try [podman](https://podman.io/] container engine. The benefits I can think of:

  • The whole engine is open-source, unlike docker
  • Almost full compatibility with Docker, including the command line
  • There are migration path from Docker and Docker compose
  • It doesn't require a daemon to run containers
  • It supports running containers rootless mode
  • It is lightweight
  • It can be integrated seamlessly with Kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants