Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Refactor table output format #6481

Closed
Abyss-lord opened this issue Feb 19, 2025 · 1 comment · Fixed by #6483
Closed

[Improvement] Refactor table output format #6481

Abyss-lord opened this issue Feb 19, 2025 · 1 comment · Fixed by #6483
Assignees
@Abyss-lord
Labels
improvement Improvements on everything

Comments

@Abyss-lord
Copy link
Contributor

What would you like to be improved?

Currently, the TableFormat output can only be verified through integration tests (IT), not unit tests (UT). Additionally, when handling large datasets, the table displays all rows without limit, which may impact readability.

How should we improve?

Refactor the table output format logic ,Making it easier to test and scale.
@Abyss-lord Abyss-lord added the improvement Improvements on everything label Feb 19, 2025
@Abyss-lord
Copy link
Contributor Author

@justinmclean plz assign this task to me.

Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Feb 19, 2025
@Abyss-lord
[apache#6481] improve(CLI): Refactor table output format
28e3c13 
Refactor table output format, make  it easier to test and scale.
@Abyss-lord Abyss-lord mentioned this issue Feb 19, 2025
Merged
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Feb 19, 2025
@Abyss-lord
[apache#6481] improve(CLI): Refactor table output format
9f9cbd8 
Rename the constant.
Abyss-lord added a commit to Abyss-lord/gravitino that referenced this issue Feb 20, 2025
@Abyss-lord
[apache#6481] improve(CLI): Refactor table output format
0b64b08 
fix some code.
justinmclean pushed a commit that referenced this issue Feb 21, 2025
@Abyss-lord
[#6481] improve(CLI): Refactor table output format (#6483)
4ffe56c 
### What changes were proposed in this pull request?

Refactor table output format, make  it easier to test and scale.

### Why are the changes needed?

Fix: #6481 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

table format test

```bash
gcli metalake list -i  --output table

+-------------------+
|     Metalake      |
+-------------------+
| demo              |
| cli_demo          |
| demo_metalake     |
| test_cli_metalake |
| tyy               |
| demo3             |
+-------------------+

gcli metalake details -i --output table  -m demo_metalake

+---------------+-------------+
|   Metalake    |   Comment   |
+---------------+-------------+
| demo_metalake | new comment |
+---------------+-------------+

gcli catalog  list -i --output table  -m demo_metalake
+-------------------+
|      Catalog      |
+-------------------+
| File              |
| Hive_catalog      |
| Iceberg_catalog   |
| Mysql_catalog     |
| Test_hive_catalog |
+-------------------+

gcli catalog  details --name Hive_catalog  -i --output table  -m demo_metalake
+--------------+------------+----------+-------------+
|   Catalog    |    Type    | Provider |   Comment   |
+--------------+------------+----------+-------------+
| Hive_catalog | RELATIONAL | hive     | new comment |
+--------------+------------+----------+-------------+
```

plainformat test
```bash
gcli metalake list -i
# demo
# cli_demo
# demo_metalake
# test_cli_metalake
# demo3

gcli metalake details -i  -m demo_metalake
# demo_metalake, new comment

gcli catalog  list -i   -m demo_metalake
# File
# Hive_catalog
# Iceberg_catalog
# Mysql_catalog
# Test_hive_catalog

gcli catalog  details --name Hive_catalog  -i  -m demo_metalake
# Hive_catalog, RELATIONAL, hive, new comment
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abyss-lord Abyss-lord

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6481] improve(CLI): Refactor table output format Abyss-lord/gravitino
1 participant
@Abyss-lord