Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep #6459

Closed
zzzk1 opened this issue Feb 15, 2025 · 0 comments · Fixed by #6460
Closed
Assignees
Labels
0.9.0 Release v0.9.0 improvement Improvements on everything

Comments

@zzzk1
Copy link
Contributor

zzzk1 commented Feb 15, 2025

What would you like to be improved?

E2E testing system utilizes Selenium as the preferred framework. Indeed, using Selenium offers a wait function rather than relying on the Thread function. Additionally, implementing a try-catch block is often unnecessary.

How should we improve?

use explicit waits like: Wait<WebDriver> wait = new WebDriverWait(driver, Duration.ofSeconds(2)); not the Thread.Sleep

@zzzk1 zzzk1 added the improvement Improvements on everything label Feb 15, 2025
@zzzk1 zzzk1 changed the title [Improvement] Use the implicitly wait feature provided by Selenium to replace Thread.Sleep [Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep Feb 25, 2025
@jerryshao jerryshao added the 0.9.0 Release v0.9.0 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9.0 Release v0.9.0 improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants